Upgrade to Scala.js 1.16.0. #20294
Merged
Upgrade to Scala.js 1.16.0. #20294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… this type in JS super call. When doing a super call to a method of a path-dependent JS super class, the `superClass.typeRef` is only valid as seen from the super class' thisType. We need to rebase it with `asSeenFrom` to be in the context of the current class' thisType. Forward port of the upstream commit scala-js/scala-js@3cef9d0
…n JS ctors. Previously, we moved all statements in the constructors after the super constructor call. However, it turns out that there are statements that must be kept before, notably local `val`s generated for default arguments to the super constructor. We now keep statements where they are by default. We only move statements of the form `C.this.field = ident;`, which are the only ones that require access to `this`. Forward port of the upstream commit scala-js/scala-js@2e4594f
Code changes are forward ports of the following refactorings: * Remove the parameters to StoreModule IR nodes. scala-js/scala-js@659d518 * Refactor: Make FieldName a composite of ClassName and SimpleFieldName. scala-js/scala-js@723663b
|
Reassigning to @mbovel because bishabosha is under water already. |
mbovel
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit messages mention the upstream commits that were forward ported.
Tests come for free in the "Upgrade to Scala.js 1.x.0." commits.